Skip to content
  • Lukas Reschke's avatar
    Verify authentication before initializing apps and routing · 1c75b732
    Lukas Reschke authored
    The current behaviour of the authenticion logic in base.php prevents REST APIs in ownCloud applications to work.
    
    Because `!self::$CLI` is usually always a true statement the previously above block was entered which returned, thus the authentication logic for this part does not trigger in.
    
    This can be reproduced by installing apps such as the News app and issuing the following command:
    
    `curl -u admin:admin http://localhost/index.php/apps/news/api/v1-2/feeds`
    
    The following parts needs to get throughly tested:
    
    - [ ] OCS
    - [ ] remote.php's DAV features
    - [ ] Regular login features
    
    This bug affects master and stable7. I'd propose that we merge this for 8.0 since this has the potential to break every component that relies on Basic Auth features. A backport would also be very nice.
    
    Remark to myself: We really need to move out the authentication code for 8.1 out of base.php - I already have a local branch that does that somewhere which I will get in shape for 8.1... - This untested code is a night-mare.
    
    Fixes itself.
    1c75b732