From 0d9534eb4b7bb0c1f62e32397fc1f7166934a32e Mon Sep 17 00:00:00 2001
From: Arthur Schiwon <blizzz@owncloud.com>
Date: Fri, 22 Jun 2012 12:42:07 +0200
Subject: [PATCH] LDAP: cheaper userExists() implementation
---
apps/user_ldap/user_ldap.php | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/apps/user_ldap/user_ldap.php b/apps/user_ldap/user_ldap.php
index 9281aebe81..48e7d429fc 100644
--- a/apps/user_ldap/user_ldap.php
+++ b/apps/user_ldap/user_ldap.php
@@ -124,7 +124,19 @@ class OC_USER_LDAP extends OC_User_Backend {
* @return boolean
*/
public function userExists($uid){
- return in_array($uid, $this->getUsers());
+ //getting dn, if false the user does not exist. If dn, he may be mapped only, requires more checking.
+ $dn = OC_LDAP::username2dn($uid);
+ if(!$dn) {
+ return false;
+ }
+
+ //if user really still exists, we will be able to read his cn
+ $cn = OC_LDAP::readAttribute($dn, 'cn');
+ if(!$cn || empty($cn)) {
+ return false;
+ }
+
+ return true;
}
}
--
GitLab