From 310424db5d57536edcc9238224415756a1c8a624 Mon Sep 17 00:00:00 2001
From: Lukas Reschke <lukas@owncloud.com>
Date: Sat, 10 Jan 2015 11:50:07 +0100
Subject: [PATCH] Use isset() instead of strlen()
Isset is a native language construct and thus A LOT faster than using strlen()
On my local machine this leads to a 1s performance gain for about 1 million paths. Considering that this function will be called a lot for every file operation this makes a noticable difference.
---
lib/private/files/view.php | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/private/files/view.php b/lib/private/files/view.php
index f1c15e197d..034c49a905 100644
--- a/lib/private/files/view.php
+++ b/lib/private/files/view.php
@@ -1278,8 +1278,10 @@ class View {
private function assertPathLength($path) {
$maxLen = min(PHP_MAXPATHLEN, 4000);
- $pathLen = strlen($path);
- if ($pathLen > $maxLen) {
+ // Check for the string length - performed using isset() instead of strlen()
+ // because isset() is about 5x-40x faster.
+ if(isset($path[$maxLen])) {
+ $pathLen = strlen($path);
throw new \OCP\Files\InvalidPathException("Path length($pathLen) exceeds max path length($maxLen): $path");
}
}
--
GitLab