From 51d33768b84fe8467258bfe67a1f9cd7e0f0913a Mon Sep 17 00:00:00 2001
From: Brice Maron <brice@bmaron.net>
Date: Sun, 24 Jun 2012 21:30:14 +0000
Subject: [PATCH] Prevent errors and mini enhancement of saved window in
bookmarks
---
apps/bookmarks/bookmarksHelper.php | 3 ++-
apps/bookmarks/templates/addBm.php | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/apps/bookmarks/bookmarksHelper.php b/apps/bookmarks/bookmarksHelper.php
index 01b551111e..92baac2f51 100644
--- a/apps/bookmarks/bookmarksHelper.php
+++ b/apps/bookmarks/bookmarksHelper.php
@@ -90,7 +90,8 @@ function addBookmark($url, $title, $tags='') {
if(empty($title)) {
$metadata = getURLMetadata($url);
- $title = $metadata['title'];
+ if(isset($metadata['title'])) // Check for problems fetching the title
+ $title = $metadata['title'];
}
if(empty($title)) {
diff --git a/apps/bookmarks/templates/addBm.php b/apps/bookmarks/templates/addBm.php
index 534bafe588..357e0a18f2 100644
--- a/apps/bookmarks/templates/addBm.php
+++ b/apps/bookmarks/templates/addBm.php
@@ -6,5 +6,6 @@
</head>
<body>
<div class="message"><h1>Saved!</h1></div>
+ <a href="javascript:self.close()" >Close the window</a>
</body>
</html>
\ No newline at end of file
--
GitLab