From 5c9178f85161c90c4c58c6ab68b2828938908845 Mon Sep 17 00:00:00 2001 From: Robin Appelman <icewind1991@gmail.com> Date: Sun, 28 Aug 2011 19:36:23 +0200 Subject: [PATCH] Fixed a bug in appconfig, where an initially empty set value led to endless duplicates of this app/key pair. Path by Elias Probst <mail@eliasprobst.eu> --- lib/appconfig.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/appconfig.php b/lib/appconfig.php index 06281d3858..c64a15b893 100644 --- a/lib/appconfig.php +++ b/lib/appconfig.php @@ -114,10 +114,10 @@ class OC_Appconfig{ */ public static function setValue( $app, $key, $value ){ // Does the key exist? yes: update. No: insert - $exists = self::getValue( $app, $key, null ); + $exists = self::getKeys( $app ); // null: does not exist - if( is_null( $exists )){ + if( !in_array( $key, $exists )){ $query = OC_DB::prepare( 'INSERT INTO *PREFIX*appconfig ( appid, configkey, configvalue ) VALUES( ?, ?, ? )' ); $query->execute( array( $app, $key, $value )); } -- GitLab