diff --git a/lib/private/util.php b/lib/private/util.php index 5097174ac110284b4f7671e125f46878ffdb8a02..304db827a1a2815e96bb7a52dbbb0b2d7742d7f1 100755 --- a/lib/private/util.php +++ b/lib/private/util.php @@ -847,8 +847,10 @@ class OC_Util { */ public static function getDefaultPageUrl() { $urlGenerator = \OC::$server->getURLGenerator(); - if (isset($_REQUEST['redirect_url'])) { - $location = urldecode($_REQUEST['redirect_url']); + // Deny the redirect if the URL contains a @ + // This prevents unvalidated redirects like ?redirect_url=:user@domain.com + if (isset($_REQUEST['redirect_url']) && strpos($_REQUEST['redirect_url'], '@') === false) { + $location = $urlGenerator->getAbsoluteURL(urldecode($_REQUEST['redirect_url'])); } else { $defaultPage = OC_Appconfig::getValue('core', 'defaultpage'); if ($defaultPage) {