From f919230f63aade2df7b12a9c9ab28c7cd59868d4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Schie=C3=9Fle?= <schiessle@owncloud.com>
Date: Tue, 22 Jan 2013 17:59:33 +0100
Subject: [PATCH] remove inline JavaScript
---
apps/files_trashbin/js/part.list.php | 19 +++++++++++++++++++
apps/files_trashbin/templates/part.list.php | 13 +------------
2 files changed, 20 insertions(+), 12 deletions(-)
create mode 100644 apps/files_trashbin/js/part.list.php
diff --git a/apps/files_trashbin/js/part.list.php b/apps/files_trashbin/js/part.list.php
new file mode 100644
index 0000000000..c4ecd1ca95
--- /dev/null
+++ b/apps/files_trashbin/js/part.list.php
@@ -0,0 +1,19 @@
+<?php
+/**
+ * Copyright (c) 2013 Bjoern Schiessle <schiessle@owncloud.com>
+* This file is licensed under the Affero General Public License version 3 or
+* later.
+* See the COPYING-README file.
+*/
+
+// Set the content type to Javascript
+header("Content-type: text/javascript");
+
+// Disallow caching
+header("Cache-Control: no-cache, must-revalidate");
+header("Expires: Sat, 26 Jul 1997 05:00:00 GMT");
+
+echo "
+var disableDownloadActions = true;
+var disableSharing = true;
+";
diff --git a/apps/files_trashbin/templates/part.list.php b/apps/files_trashbin/templates/part.list.php
index 205e11c286..c7783e8a4f 100644
--- a/apps/files_trashbin/templates/part.list.php
+++ b/apps/files_trashbin/templates/part.list.php
@@ -1,15 +1,4 @@
-<script type="text/javascript">
-<?php if ( array_key_exists('disableSharing', $_) && $_['disableSharing'] == true ) :?>
- var disableSharing = true;
-<?php else: ?>
- var disableSharing = false;
-<?php endif; ?>
-<?php if ( array_key_exists('disableDownloadActions', $_) && $_['disableDownloadActions'] == true ) :?>
- var disableDownloadActions = true;
-<?php else: ?>
- var disableDownloadActions = false;
-<?php endif; ?>
-</script>
+<script type="text/javascript" src="<?php echo OC_Helper::linkTo('files_trashbin/js', 'part.list.php');?>"></script>
<?php foreach($_['files'] as $file):
$simple_file_size = OCP\simple_file_size($file['size']);
--
GitLab