GitLab

See https://github.com/owncloud/gallery-old/commit/c080dfe87d5eb1de8aa27b1836629b57b0316004

Fixes https://github.com/owncloud/core/issues/21451

There were code paths that nowadays call ISession::login directly thus bypassing the desired regeneration of the session ID. This moves the session regeneration deeper into the session handling and thus ensures that it is always called. Furthermore, I also added the session regeneration to the remember me cookie plus added some test case expectations for this.

Otherwise static code scanners will complain about this.

use method exists lookup to be safe and not break on old hhvm versions

add test that checks if type hint is preferred over annotation

This patch makes sure, that the value can always be parsed correctly.

This one is available since APCu 4.0, since we require APCu 4.0.6 this works fine. Also it brings us PHP 7 compatibility and thus fixes https://github.com/owncloud/core/issues/21095

This approach is not valid anymore. It initially was added for jobs
of non existing apps. But jobs of non-existing apps can not be created
so they will never be executed and so this call just catches other
cases which were not intended.

This reverts commit 4f4ad724.

We were still using the lecagy class OC_Config all over the place. Which
was a wrapper around the new class OC\Config