1. 14 Nov, 2014 2 commits
  2. 24 Oct, 2014 1 commit
  3. 30 May, 2014 1 commit
    • Thomas Müller's avatar
      - fix dropTable() and introduce tableExists() · 999f6216
      Thomas Müller authored
      - kill replaceDB() - this function is unused and it's implementation obviously wrong
      - add method annotation OC_DB_StatementWrapper::fetchAll
      - remove duplicate code in Test_DBSchema and reuse OC_DB::tableExists
      - remove unused variables
      999f6216
  4. 13 May, 2014 1 commit
  5. 28 Mar, 2014 1 commit
  6. 07 Feb, 2014 1 commit
  7. 06 Feb, 2014 1 commit
  8. 16 Jan, 2014 1 commit
  9. 21 Dec, 2013 1 commit
    • Andreas Fischer's avatar
      Remove OC_DB_StatementWrapper::numRows(). · 63a2bea7
      Andreas Fischer authored
      Using this method will result in an unneccesary extra SQL query (which also may
      return an incorrect result because the underlying table changed in the
      meantime).
      
      In general:
      
      If you are performing an UPDATE, DELETE or equivalent query,
      OC_DB_StatementWrapper::execute() will already give you the number of
      "affected rows" via \Doctrine\DBAL\Driver\Statement::rowCount(). This will
      not work for SELECT queries, however.
      
      If you want to know whether a table contains any rows matching your condition,
      use "SELECT id FROM ... WHERE ... LIMIT 1".
      
      If you want to know whether a table contains any rows matching your condition
      and you also need the data, use "SELECT ... FROM ... WHERE ...", then use
      one of the fetch() methods.
      
      If you want to count the number of rows matching your condition, use use
      "SELECT COUNT(...) AS number_of_rows FROM ... WHERE ...", then use one of the
      fetch() methods.
      63a2bea7
  10. 30 Sep, 2013 1 commit
  11. 07 Aug, 2013 1 commit
  12. 28 Jun, 2013 1 commit