Skip to content
Snippets Groups Projects
Commit 1846aebf authored by Joas Schilling's avatar Joas Schilling
Browse files

Use md5() of the original name instead of uniqid() for slugifying

Previously we used uniqid() here.
However this means that the behaviour is not reproducable, so
when uploading files into a "empty" folder, the folders name is
different.

If there would be a md5() hash collition, the deduplicate check
will spot this and append an index later, so this should not be
a problem.

Fix #6722
parent b861e1d6
Branches
No related tags found
No related merge requests found
......@@ -216,6 +216,7 @@ class Mapper
* @return string
*/
private function slugify($text) {
$originalText = $text;
// replace non letter or digits or dots by -
$text = preg_replace('~[^\\pL\d\.]+~u', '-', $text);
......@@ -237,7 +238,17 @@ class Mapper
$text = preg_replace('~\.+$~', '', $text);
if (empty($text)) {
return uniqid();
/**
* Item slug would be empty. Previously we used uniqid() here.
* However this means that the behaviour is not reproducible, so
* when uploading files into a "empty" folder, the folders name is
* different.
*
* If there would be a md5() hash collision, the deduplicate check
* will spot this and append an index later, so this should not be
* a problem.
*/
return md5($originalText);
}
return $text;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment