Skip to content
Snippets Groups Projects
Commit f0e6876f authored by Lukas Reschke's avatar Lukas Reschke
Browse files

Merge pull request #12488 from owncloud/activity_group_multiple_conditions

activitymanager: concatenate queries with 'or'
parents 2c157da1 bf2c9be0
Branches
No related tags found
No related merge requests found
......@@ -247,16 +247,28 @@ class ActivityManager implements IManager {
* @return array
*/
function getQueryForFilter($filter) {
$conditions = array();
$parameters = array();
foreach($this->extensions as $extension) {
$c = $extension();
if ($c instanceof IExtension) {
$result = $c->getQueryForFilter($filter);
if (is_array($result)) {
return $result;
list($condition, $parameter) = $result;
if ($condition && is_array($parameter)) {
$conditions[] = $condition;
$parameters = array_merge($parameters, $parameter);
}
}
}
}
if (empty($conditions)) {
return array(null, null);
}
return array(' and ((' . implode(') or (', $conditions) . '))', $parameters);
}
}
......@@ -87,11 +87,14 @@ class Test_ActivityManager extends \Test\TestCase {
}
public function testQueryForFilter() {
$this->activityManager->registerExtension(function() {
return new SimpleExtension();
});
$result = $this->activityManager->getQueryForFilter('filter1');
$this->assertEquals(
array(
'`app` = ? and `message` like ?',
array('mail', 'ownCloud%')
' and ((`app` = ? and `message` like ?) or (`app` = ? and `message` like ?))',
array('mail', 'ownCloud%', 'mail', 'ownCloud%')
), $result
);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment